// remarks added by pashute

// +. means pashute added or modified one or several lines of code

// .. means pashute only added the comment

using System;

// +.

public class Program

{

    public static void Main()

    {

        Console.WriteLine("Hello World");

    }

}

​

// +. added this class inferred from bottom of supplied code

public class Same

{

    public int row {get; set;} //+. changed from "rows" to "row" for clarity

    public int column { get; set; }

}

​

//+. inferred from code

public class ExpenseManager

{

    public void AddExpense(Same same)

    {

        //.. do something here

    }

}

​

public static class Sudoku{ //+.

    public static void createSudoku() //+.

    {

        Random rnd = new Random(); //+. inferred from code

        ExpenseManager myExpenseManager = new ExpenseManager(); //+.

        //.. These initialize each int in the arrays to zero 

        //.. success-score (expense) array. Better to call it xpenseArray...

        int[,] randomNumbersArray = new int[9,9]; //+. inferred from code

        //.. randomly filled array 

        //.. probably representing row and column from an existing Sudoku game

        //.. Better to call it rowcolArray and have it two dimensional

        //.. output shows:

        //..  rnArray1: 1,0,2, 6,5,6, 6,2,5

        //..  rnArray2: 3,6,7, 5,8,7, 3,8,7

        int[] randomNumbersArray1 = new int[9]; //+. inferred from output screenshot 

        int[] randomNumbersArray2 = new int[9]; //+. inferred from output screenshot

        for (var i=0; i<9; i++)

        {

            randomNumbersArray1[i] = rnd.Next(0,9); //+. should be (1,9) no?

            randomNumbersArray2[i] = rnd.Next(0,9); //+. should be (1,9) no?

        }

        /* I would do

        * int[,] rowcolArray = new int[9,9];

        * for (var i=0; i<9; i++)

        *   for (var j=0; j<9; j++)

        *       rowcolArray[i,j]= rnd.Next(1,9);

        */

        //.. randomly filled array

        //.. probably representing square and place in square of Sudoku game

        //.. better call it squaresArray and have it two dimensional. 

        int[] randomNumbersArray12 = new int[9]; //+. inferred from code

        int[] randomNumbersArray22 = new int[9]; //+. inferred from code

        for (var i=0; i<9; i++)

        {

            randomNumbersArray12[i] = rnd.Next(0,9); //+. should be (1,9) no?

            randomNumbersArray22[i] = rnd.Next(0,9); //+. should be (1,9) no?

        }

        /* I would do

        * int[,] squaresArray = new int[9,9];

        * for (var i=0; i<9; i++)

        *   for (var j=0; j<9; j++)

        *       squaresArray[i,j]= rnd.Next(1,9);

        */

        int[] randomNumbersArray13 = new int[9];

        int[] randomNumbersArray23 = new int[9];

        int va12, vb12;  //.. variable a and variable b, initiated to zero

                         //.. better to call them va and vb

​

        randomNumbersArray13[0] = 122;

        randomNumbersArray23[0] = 12212;

​

        //.. === Here goes ===

        for (int k = 0; k < 9; k++) //.. loop 9 times 

        {

            Same same = new Same(); //+. changed variable name from Class to same for clarity

            //.. randomly choose va and vb

            va12 = rnd.Next(0, 9);  

            vb12 = rnd.Next(0, 9);

            //.. the following code checks the diagonal of array1 and array2 (the rowcolArray)

            //.. probably meant to check each pair in turn...

            for (int i = 0; i < 9; i++) //.. iterate 9 times (possible source of mistake in code...)

            {

                // 

                while (va12 == randomNumbersArray1[i] && vb12 == randomNumbersArray2[i])

                {

                    va12 = rnd.Next(0, 9);

                    vb12 = rnd.Next(0, 9);

                }

            }

            //.. the following code checks the diagonal of array21 and array22 (the squaresArray)

            //.. looking at 1,1 then 2,2 then 3,3 etc. 

            //.. probably meant to check each pair in turn...

            for (int i = 0; i < 9; i++)

            {

                while (va12 == randomNumbersArray12[i] && vb12 == randomNumbersArray22[i])

                {

                    va12 = rnd.Next(0, 9);

                    vb12 = rnd.Next(0, 9);

                }

            }

            //.. it seems you wanted to check that you are not repeating

            //.. instead you are checking the whole array even though most of it is still zero

            //.. here also you are checking the "diagonal" of the sudoku array: 1,1 then 2,2 then 3,3...

            for (int i = 0; i < randomNumbersArray13.Length; i++) //.. that's 9 iterations

            {

                //.. va and vb will never be like rnArray13[0] and rnArray23[0] 

                //.. because va and vb are between 1 and 9 while the array is always 

                while (va12 == randomNumbersArray13[i] && vb12 == randomNumbersArray23[i])

                {

                    va12 = rnd.Next(0, 9);

                    vb12 = rnd.Next(0, 9);

                }

            }

​

            same.row = va12;

            same.column = vb12;

            randomNumbersArray12[k] = va12;

            randomNumbersArray22[k] = vb12;

            randomNumbersArray[va12, vb12] = 3;

            myExpenseManager.AddExpense(same);

​

            /* 

            * .. I would do: 

            * for (var i=0;i<9;i++)

            *   for (var j=0;j<9;j++)

            *   {

            *     // if non-unique in the row/column or non-unique in the square, then re-randomize

            *     while( va == rowcolArray[i,j] || va == squaresArray[i,j])

            *       v = rnd.Next(1,9);

            *     

            *     // and now use the unique number in your two dimensional array

            *     unqiqueArray[i,j] = v;

            *     scoreArray[i,j] = 3;

            *

            *     same = new Same(i,j);

            *     myExpenseManager.AddExpense(same);

            *    }

            *  }

            */

​

        }

    }

}