using System;

​

namespace Hazi_feladat_Tetelek_alkalmazasa

{

   public class Program

    {

        public static void Main(string[] args)

        {

            Random veletlen = new Random();

            int[] velszamok = new int[28];

​

            Console.WriteLine("-- all numbers --");

            for (int i = 0; i < 28; i++)

            {

                velszamok[i] = veletlen.Next (-10,10);

                Console.WriteLine(velszamok[i]); // here is where it should go

            }

            // Console.WriteLine( velszamok [i] ) this will not work here, because the variable i you are referencing inside the brackets is only valid inside the for loop

            // because you are declaring it inside the loop

            // the console statement works if you put it in the loop - see above

            int darab_negativ = 0;

            int darab_pozitiv = 0;

            int darab_0 = 0;

​

            for (int i = 0; i < 28; i++)

            {

                if (velszamok[i] < 0) 

                {

                    darab_negativ++;

                }

            }

​

            for (int i = 0; i < 28; i++)

            {

                if (velszamok[i] > 0)

                {

                    darab_pozitiv++;

                }

            }

            for (int i = 0; i < 28; i++)

            {

                if (velszamok[i] == 0)  

                {

                    darab_0++;

                }

            }

            // A

            Console.WriteLine("-------");

            Console.WriteLine("number of negative numbers: " + darab_negativ);

            Console.WriteLine("number of positive numbers: " + darab_pozitiv );

            Console.WriteLine("number of zeros: " + darab_0 );

            Console.WriteLine("-------");

            if (darab_negativ > darab_pozitiv)

            {

                Console.WriteLine("a.) feladat: Több negatív szám van. " + "Negatív számok darabszáma: " + darab_negativ + ", "  + "Pozitív számok darabszáma: " + darab_pozitiv + ", " + " 0-k száma: " + darab_0);

            }

            else if (darab_negativ < darab_pozitiv)      

            {

                Console.WriteLine("a.) feladat: Több pozitív szám van. " + "Pozitív számok darabszáma: " + darab_pozitiv + ", " + "Negatív számok darabszáma: " + darab_negativ + ", " + " 0-k száma: " + darab_0);

            }

            else if  (darab_negativ == darab_pozitiv)

            {

                Console.WriteLine("a.) feladat: Egyenlő pozitív és negatív szám van. " + "Negatív számok darabszáma: " + darab_negativ + ", " + "Pozitív számok darabszáma: " + darab_pozitiv + ", " + " 0-k száma: " + darab_0);

            }

            // B

            int darab_7 = 0;

​

            for (int i = 0; i < 28; i++)

            {

                if (velszamok[i] == 7 | velszamok[i] == -7) // if you also want to find every negative 7 (-7), you can add a second condition with the Logical OR operator "|"

                {

                    darab_7++;

                }

            }

            Console.WriteLine("b.) feladat: A 7-esek száma: " + darab_7);

            // C

            int j = 0;

            bool Van_0;

​

            while (j < 28 && velszamok[j] !=0 )

            {

                j++;

            }

            Van_0 = j < 28;

            if (Van_0 == true)

            {

                j++; // Okay so this is your j+1 (the ++ basically increments the variable j by one). you can't write this in Console.WriteLine statements because the + sign is evaluated differently and will combine rather than add values

                // FYI: you add 1 to j because of the way arrays are counted - they start at 0 and not at 1

                Console.WriteLine("c.) feladat: Van a számok közt 0. A 0 helye: " + j +".");

            }

            else

            {

                Console.WriteLine("c.) feladat: Nincs a számok közt 0.");

            }

            // Your solution only works for 1 zero though, it will not tell you the postion of the other zeros in case you have more (is that what you wanted?) 

            // D

            // int m; 

            // m was not accepted in the loop because you already declared it here and you are declaring it again in the for loop

            // so either declare it in the for loop or you declare it here, then the for loop looks like this: 

            // for ( m = 0; m > 28; m++ )

            int osszeg;

            double atlag;

            osszeg = 0;

            for (int m = 0; m < 28; m++) // your second mistake was here by writing "m <= 28". this means that the loop will run 29 times but your array only has a length of 28.

            // this will cause an error because the last position in your array is velszamok[27] (0-27 array entries)

            {

                if (velszamok[m] < 0)

                {

                    osszeg = osszeg + velszamok[m];

                }

            }

            atlag = osszeg / 28.0;

            Console.WriteLine("d.) A negatív számok átlaga: " + atlag);

            // E

            int n; // same mistake as above, so here is the other way

            // i have rewritten this a bit because your solution wasn't working, it was getting a positive number, but not the smallest, it was getting the last positive number

            int smallestPositive = 10; // here i declare a variable with the value 10, because we know that the largest positive number can be 10

​

            for (n = 0; n < 28; n++)

            {

                if (velszamok[n] > 0 && velszamok[n] < smallestPositive) // in this condition i check if the number in the array at pposition n is larger than 0 

                // and (logical and operator &&) smaller than the number that is stored in smallestPositive.

                {

                    smallestPositive = velszamok[n]; // if true, then i assign this number

                }

            }

            Console.WriteLine("A pozitív számok közül a legkisebb: " + smallestPositive); 

            // F

            int largestNegative = 0; // same as above we just start with 0

            for (int o = 0; o < 28; o++)

            {

                if (velszamok[o] < 0 && velszamok[o] < largestNegative)

                {

                    largestNegative = velszamok[o];

                }

            }

            Console.WriteLine("A negatív számok közül a legnagyobbb: " + largestNegative); 

​

        }

    }

}