//  To enable debugging uncomment the definition, comment the undefinition. Do the opposite to disable debugging.

//  Don't comment or uncomment them both at once, it doesn't seem to work reliably without a positive instruction one way or the other.

//#define DEBUG

#undef DEBUG

​

using System;

​

public class Challenge{

​

    public static void Main(){

​

        int userWin = 0;

        int computerWin = 0;

​

//  This may be overkill for this use, you could just change "int winsNeeded = (whatever);" directly, as needed for debugging purposes. This is a way you can legitimately

//  use definitions though, so it seemed a good place for an example. As programs get more complicated and you have to debug a multitude of variables at once it can be

//  useful to have a global debug flag that turns debug mode and any assoicated output on and off. It doesn't have to be a definition, you can use a global int or

//  const or bool or whatever in the same way.

//  The sorts of output involved would be raw variables you're dumping to the screen at points in the code to check they're getting the expected values at the expected

//  times, things like that. 

//  

#if DEBUG

        Console.WriteLine("Debug enabled.");

        int winsNeeded = 1;     //  We're testing end conditions so we want to reach them as quickly as possible.

#else

        int winsNeeded = 2;

#endif

​

        //  Initiate a best 2 out of three.

        while (userWin < winsNeeded && computerWin < winsNeeded)    {

            Random rnd = new Random();

            int userWeapon = 0;

            string userInput = "";

​

            // There was a for() loop started here once. There isn't any more. 

            Console.WriteLine("User, let us play a little game.  Best two out of three wins!");

            Console.WriteLine("User, please choose your weapon from the following list:");

            Console.WriteLine("Rock, Paper, or Scissors");

            userInput = Console.ReadLine();

​

            //  Compare user input to list of valid options, if valid option exists, assign integer value accordingly.

            if (userInput == "Rock" || userInput == "rock" || userInput =="R" || userInput == "r"){

                userWeapon = 1;

                Console.WriteLine("User has chosen Rock as their weapon");

            }

            else if (userInput == "Paper" || userInput == "paper" || userInput =="P" || userInput == "p"){

                userWeapon = 2;

                Console.WriteLine("User has chosen Paper as their weapon");

            }

            else if (userInput == "Scissors" || userInput == "scissors" || userInput =="S" || userInput == "s"){

                userWeapon = 3;

                Console.WriteLine("User has chosen Scissors as their weapon");

            }

​

            //  Add two secret cheat options.

            else if (userInput == "Sword" || userInput == "sword"){

                userWeapon = 4;

                Console.WriteLine("Ah, the user is thinking outside the box.  That is cheating.  I will have to cheat as well!");

            }

            else if (userInput == "Pen" || userInput == "pen"){

                userWeapon = 5;

                Console.WriteLine("Ah, the user is thinking outside the box.  That is cheating.  I will have to cheat as well!");

            }

​

            //  If validity fails, write error and restart.

            else {

                Console.WriteLine("The user input is not valid.  Please try again.");

                Console.WriteLine();

            }

​

            // Test if user is cheating

            if (userWeapon <= 3){

                int computerWeapon = rnd.Next(1,3);

                if (computerWeapon == 1){   //  After the first if() these should be else if(). Only one can be true, there's not point comparing beyond the first match.

                                            //  Or you could switch(). In this scenario it doesn't impact the functionality of the code, but it doesn't hurt to minimize

                                            //  the work the computer is doing.

                    Console.WriteLine("Computer chooses Rock as its weapon.");

                }

                else if (computerWeapon == 2){

                    Console.WriteLine("Computer has chosen Paper as its weapon.");

                }

                else {  //  Unlike the example down the bottom, in this case we'll handle all possibilities by just including the error case in with

                        //  a non-error case and pretend it never happened. So we finish with an else(). Errors are unlikely here, as they now are below,

                        //  and here we'll choose to ignore them entirely. We still allow for them though.

                    Console.WriteLine("Computer has chosen Scissors as its weapon.");

                }

                Console.WriteLine();

                Console.WriteLine("Preapare for Battle");

                Console.WriteLine();

​

                // As with above, but doing this here actually breaks the logic - the else() at the end is only attached to the last if()

                // [if (userWeapon == 3 && computerWeapon == 2){] so if one of the first three if()s is satisfied then that else() will still run.

                if (userWeapon == computerWeapon){

                    Console.WriteLine("User and Computer have tied.");

                    Console.WriteLine("We will ignore this round.");

                }

                else if (userWeapon == 1 && computerWeapon == 3){

                    Console.WriteLine("User wins this round.");

                    userWin++;

                }

                else if (userWeapon == 2 && computerWeapon == 1){

                    Console.WriteLine("User wins this round.");

                    userWin++;

                }

                else if (userWeapon == 3 && computerWeapon == 2){

                    Console.WriteLine("User wins this round.");

                    userWin++;

                }

                else {

                    Console.WriteLine("Computer has won this round.");

                    Console.WriteLine();

                    computerWin++;

                }

            }

            else if (userWeapon == 4){

                Console.WriteLine("Computer has chosen Pen as its weapon.");

                Console.WriteLine("You tried to cheat, and now you have lost. My Pen is mightier than your Sword!");

                Console.WriteLine();

                computerWin++;

            }

            else if (userWeapon == 5){

                Console.WriteLine("Computer has chosen Sword as its weapon.");

                Console.WriteLine("Silly mortal! You have brought a Pen to a Sword fight!.. AHHHHH   You win?!  How does a Pen defeat a Sword????");

                Console.WriteLine();

                userWin++;

            }

​

            Console.WriteLine("User has won " + userWin + " round; Computer has won " + computerWin + " round.");

            Console.WriteLine();

      }     //  end while() (Adding things like this sometimesdoesn't hurt to make code slightly easier to read helps me keep my place. :))

​

        //  If these two conditions aren't met then nothing is output and the program just stops. In this specific case they should be met in all circumstances because they're

        //  tied to the while() loop variables. You should STILL be handling all possibilities, and a catch-all else() just to indicate an unexpected situation has arisen

        //  never hurts. 

        //  In this case the else() catch-all should only fire if there's an actual unexpected error, rather than a mismatch in hard-coded numbers, so this logic structure could

        //  be used to trigger real error handling code instead of, or as well as, outputting an indication that and error has occurred.

        //  Also, as above, the should be an else if() here regardless.

        if (userWin == winsNeeded){

            Console.WriteLine("The user has won!");

        }

        else if (computerWin == winsNeeded){

            Console.WriteLine("The computer has won!");

        }

        else    //  We do not apply the DEBUG if-check here because this is an error output, not a debug output.

            Console.WriteLine("Someone has won. Fuck knows who.");

    }

}

​